Skip to content

Tools for generating non-global unstructured meshes #86

Open
kestonsmith-noaa wants to merge 44 commits intoNOAA-EMC:developfrom
kestonsmith-noaa:RWPSMeshGenTools
Open

Tools for generating non-global unstructured meshes #86
kestonsmith-noaa wants to merge 44 commits intoNOAA-EMC:developfrom
kestonsmith-noaa:RWPSMeshGenTools

Conversation

@kestonsmith-noaa
Copy link

Pull Request Summary

Tools for generating non-global unstructured WW3 meshes are added to WW3-tools. This includes tools for interpolating multiple bathymetry datasets to mesh nodes.

Description

new feature

This branch adds features for generating non-global unstructured meshes using the jigsaw mesh generator. This includes tools and scripts for forming boundaries and shorelines for meshes. Mostly geared to designing meshes with resolution dependent on topography and distance to shoreline or other points. Also includes tools for interpolating multiple bathymetry datasets to mesh nodes using Gauss-Markov smoothing with interpolation length scale dependent on local mesh resolution.

Documentation (in the form of a slide show presently) is available at:
https://docs.google.com/presentation/d/1P7M8eI6AkELXyCL1E4VQZSmJUk0EUZ344zdyeifffn8
(in progress)
reviewer suggestion:
Ali Salimi: [email protected]

Issue(s) addressed

Commit Message

Added tools for generating non-global unstructured meshes using the jigsaw mesh generator.

Check list

  • [X ] Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.

Testing

  • How were these changes tested?

Unstructured meshes were generated for work in the RWPS project.

@JessicaMeixner-NOAA
Copy link
Collaborator

@kestonsmith-noaa - Thank you for making this PR. I see that you've made a few commits since opening the PR. Can you provide a summary of what work in your opinion is still outstanding with this PR and if there are any other outstanding items for the regional mesh generation as of now?

@kestonsmith-noaa
Copy link
Author

I am filling in headers for all functions and need to write more concise quick-start instructions. I should be done with this today.

@JessicaMeixner-NOAA
Copy link
Collaborator

@kestonsmith-noaa - the recent updates seem to be beyond just adding headers and a quick-start instructions. Can you please provide an update on what is still work to be done for this PR? Is it ready for review or do you have more work you are planning?

@kestonsmith-noaa
Copy link
Author

This is ready for review now. I had to clean up some recurring longitude transformations that were specific to RWPS. These confused the local mesh generation problem unnecessarily. All set and tested now.

@JessicaMeixner-NOAA
Copy link
Collaborator

Instead of this being "RWPSMesh..." I assume this works to create any regional mesh? Should the sub directory name be "regional" ? I thought we discussed with Ali that we'd make a "regional" and "global" directory, and the existing files will be moved to global.

@kestonsmith-noaa
Copy link
Author

Yes, that sounds like a good idea. - Do you want me to make the change in this branch with the PR?

@JessicaMeixner-NOAA
Copy link
Collaborator

In this branch in this PR, make the change from RWPSMesh to regional. We can make a separate PR adding the "global" branch.

@kestonsmith-noaa
Copy link
Author

There is a problem within WW3-tools/unst_msh_gen/regional/MeshGenTemplateDirectory/MakeCoastalBoundariesGSHHS.m which will be updated shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants